Kotlin Contracts with generics! #1468
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d bring to dataframe
koperagen
reviewed
Oct 2, 2025
|
|
||
| public fun AnyCol.isList(): Boolean = typeClass == List::class | ||
| public fun AnyCol.isList(): Boolean { | ||
| contract { returns(true) implies (this@isList is ValueColumn<List<*>>) } |
There was a problem hiding this comment.
Need to consider nullability: List<*>?
is it safe?
There was a problem hiding this comment.
oh you're right, should indeed be List<*>?
|
Fine to have an experinmental PR, but to early to use this feature in 1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explored experimental generics in kotlin contracts and what they could bring to dataframe
Shall we adopt it? or wait until it's not experimental anymore?